Comments on: Rewriting a Utility http://vanemden.wordpress.com/2008/12/10/rewriting-a-utility/ Observations, Reviews, and Essays Thu, 27 Aug 2009 21:34:00 +0000 http://wordpress.com/ hourly 1 By: Michael http://vanemden.wordpress.com/2008/12/10/rewriting-a-utility/#comment-58 Michael Mon, 09 Mar 2009 18:43:05 +0000 http://vanemden.wordpress.com/?p=33#comment-58 We assume that division is slow, but is it? Why not compute the size required directly? (Also, name the function so that the caller is alerted to release the memory): <code> char* createStringFrom(int n) { int neg = n0) ++digits; if(neg)++digits; char* result = malloc(sizeof(char)*(digits+1)); result[digits] = 0; int k; int e = neg?1:0; for(k=digits-1;k>=e;--k) { char c = '0' + n%10; n = n/10; result[k] = c; } if(neg) { result[0] = '-'; } return result; }</code> We assume that division is slow, but is it? Why not compute the size required directly? (Also, name the function so that the caller is alerted to release the memory):


char* createStringFrom(int n)
{
int neg = n0) ++digits;
if(neg)++digits;
char* result = malloc(sizeof(char)*(digits+1));
result[digits] = 0;
int k;
int e = neg?1:0;
for(k=digits-1;k>=e;--k)
{
char c = '0' + n%10;
n = n/10;
result[k] = c;
}
if(neg)
{
result[0] = '-';
}
return result;
}

]]>